Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Feature project to add conversions.
This PR will result in the following new package version:
See CHANGELOG
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Updates: Conversion Support!
We have added more robust support for conversions in our data models by doing the following:
snapchat_ads__conversion_fields
variable to pass through additional conversion metrics in thestg_snapchat_ads__ad_hourly_report
,stg_snapchat_ads__ad_squad_hourly_report
andstg_snapchat_ads__campaign_hourly_report
models.dbt_project.yml
to bring in the most used conversion fieldconversion_purchases
.snapchat_ads_add_pass_through_columns
andsnapchat_ads_fill_pass_through_columns
macro checks for whether these fields already are brought in by the existing passthrough variables. This ensures there are no duplicate column errors if both the new conversion variable and the old passthrough variable are leveraged in eitherstg_snapchat_ads__*_hourly_report*
data model.conversion_purchases_value
field to the above mentionedstg_snapchat_ads__*_hourly_report*
modelDocumentation Update
snapchat_ads__conversion_fields
variable in the README.src
andstg
yml files.Under the Hood
snapchat_*_hourly_report_data
seed files with relevant conversion fields for more robust testing.Contributors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Compiled models successfully using various permutations of the passthrough columns/conversion fields vars.
If you had to summarize this PR in an emoji, which would it be?
🛝