Bug Fix: Coalesce incremental fields #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#86]
This PR will result in the following new package version: v0.13.1
No field names were changed, just the underlying behavior for null coalesces.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Bug Fixes
backfill_lifetime_sums
fields from incremental loads, as well ascohort_month_number
in the rare cases there are no orders from an incremental period. This fixes the issue of NULL values in the lifetime columns inshopify__customer_cohorts
table. (PR #86).Under the Hood:
integration_tests
for theshopify__customer_cohorts
model.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Customer validated that the incremental run worked as expected internally.
We created validation tests as well on the end model impacted, and were able to get a successful pass on our integration tests data.
If you had to summarize this PR in an emoji, which would it be?
🏃🏽