Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/variable_calendar_start #84

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Jul 8, 2024

PR Overview

This PR will address the following Issue/Feature:
#64

This PR will result in the following new package version:

v0.12.2

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature: Customizable date start

  • Updated the shopify__calendar start date to include a variable shopify__calendar_start_date. This can be set in your dbt_project.yml. If not used, the default will start at 2019-01-01. See the README for more details.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • [] docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Tested by configuring the variable and running against internal data

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli self-assigned this Jul 8, 2024
@fivetran-reneeli
Copy link
Contributor Author

will wait to regen docs til approved

@fivetran-reneeli fivetran-reneeli linked an issue Jul 8, 2024 that may be closed by this pull request
4 tasks
@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the title add variable feature/variable_calendar_start Jul 8, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli thanks for working on this PR and getting this new variable included! Generally this PR is looking good and I just have a few documentation related changes I would like you to make before approving.

Additionally, please add more details to your validation section of the PR template when not relying on our validation tests. I don't believe validation tests are needed for this change, but a quick screenshot will really help to provide more confidence to the claim that the variable works as expected.

For example a screenshot like the following highlights that the variable is working as expected and the default config is matching the expected results from before the changes.
image

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
fivetran-reneeli and others added 2 commits July 9, 2024 12:10
@fivetran-reneeli
Copy link
Contributor Author

Thanks @fivetran-joemarkiewicz ! And yeah for validations, I left the variable I had tested with in our internal notes but definitely could've screenshotted what I was looking at since there's no PII, noted for future reference.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, be sure to regenerate the docs before moving to release review. Thanks @fivetran-reneeli!

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-reneeli A small edit but otherwise lgtm!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: fivetran-catfritz <[email protected]>
@fivetran-reneeli fivetran-reneeli merged commit b259fe9 into main Jul 15, 2024
9 checks passed
@fivetran-reneeli fivetran-reneeli deleted the feature/variable_calendar_start branch July 15, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Customizable start date for shopify__calendar
3 participants