-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update partition logic with source relation #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-avinash thanks for working on these PRs! This generally looks good but I have a few requests and to make this a breaking change. Let me know if you have any questions!
packages.yml
Outdated
# version: [">=0.10.0", "<0.11.0"] | ||
- git: https://github.com/fivetran/dbt_shopify_source.git | ||
revision: bugfix/update-partition-logic-add-source-relation | ||
warn-unpinned: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to swap before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz PR should be ready for re-review. Buildkite changes are on non-model/yml files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one comment and reminder to update the package deps.
CHANGELOG.md
Outdated
[PR #74](https://github.com/fivetran/dbt_shopify/pull/74) includes the following updates: | ||
|
||
## 🚨 Breaking Changes 🚨 | ||
- Added `source_relation` to the `partition_by` clauses that determine the `customer_index` in the `int_shopify__customer_email_rollup` table. If the user is leveraging the union feature, this could change data values, so would recommend a `dbt run --full-refresh` in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same note from the source, let's remove the bit about the full refresh as it is not necessary for these models.
- Added `source_relation` to the `partition_by` clauses that determine the `customer_index` in the `int_shopify__customer_email_rollup` table. If the user is leveraging the union feature, this could change data values, so would recommend a `dbt run --full-refresh` in this case. | |
- Added `source_relation` to the `partition_by` clauses that determine the `customer_index` in the `int_shopify__customer_email_rollup` table. If the user is leveraging the union feature, this could change data values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
PR Overview
This PR will address the following Issue/Feature: dbt_shopify_source issue #77
This PR will result in the following new package version:
dbt_shopify v0.10.1
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
🐛 Bug Fixes 🪛
source_relation
to thepartition_by
clauses that determine thecustomer_index
in theint_shopify__customer_email_rollup
table.🚘 Under The Hood 🚘
integration_tests/dbt_project.yml
to ensure local testing passed on null cases.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🏃🏽♂️