[Bug Fix] Update Quickstart.yml casing #61
Conversation
* MagicBot/add-model-counts updates * Update README.md * update connector to connection --------- Co-authored-by: Avinash Kunnath <[email protected]> Co-authored-by: Avinash Kunnath <[email protected]>
There was a problem hiding this comment.
@fivetran-avinash a few change requests, suggestions, and questions before approval.
.quickstart/quickstart.yml
Outdated
| public_models: [ | ||
| "salesforce__contact_enhanced", | ||
| "salesforce__daily_activity", | ||
| "salesforce__manager_performance", | ||
| "salesforce__opportunity_enhanced", | ||
| "salesforce__opportunity_line_item_enhanced", | ||
| "salesforce__owner_performance", | ||
| "salesforce__sales_snapshot" | ||
| ] |
There was a problem hiding this comment.
Why were these removed?! We need to ensure the public models are included otherwise they will not be visible in the UI.
There was a problem hiding this comment.
@fivetran-joemarkiewicz This stumped me for a second. For some reason on my git fetch/git pull it did not pick up this quickstart.yml update.
Is it because this change was merged in September, but the last release was in July, so it picked up the release but not these updates?
UPDATE: I checked the above and only the quickstart.yml changes from the merged PR weren't brought back. I really don't remember deleting this. I hope this is just a ghost in the machine situation. In any case I'm bringing these back in.
PR Overview
This PR will address the following Issue/Feature: [#60]
This PR will result in the following new package version: 1.2.0
This updates the Quickstart configuration, so a breaking change is best practice here.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Quickstart Fixes
quickstart.ymlto match the default Salesforce connector schema. Source tables are now in upper case, and snake casing is updated to camel casing.Documentation
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
⏩