Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature union schemas #55

Merged
merged 24 commits into from
Jan 22, 2025
Merged

Feature union schemas #55

merged 24 commits into from
Jan 22, 2025

Conversation

fivetran-jamie
Copy link
Collaborator

@fivetran-jamie fivetran-jamie commented Jan 3, 2025

PR Overview

This PR will address the following Issue/Feature:
#52 by merging in and adding to #53

This PR will result in the following new package version:

v0.11.0

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature Update: Run Package on Unioned Connectors

  • This release supports running the package on multiple Mixpanel sources at once! See the README for details on how to leverage this feature.
    • This was achieved through the introduction of new unioning macros.

Please note: This is a Breaking Change in that we have a added a new field, source_relation, that points to the source connector from which the record originated. This will require running a full refresh.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates) - after databricks passes
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

devprodtest_incremental passes both steps

image

image

If you had to summarize this PR in an emoji, which would it be?

🥣

@fivetran-jamie fivetran-jamie self-assigned this Jan 3, 2025
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie this looks really good! I have a few change requests, but generally the code looks great and tested on the various iterations and didn't see any issues! Once these comments are addressed this should be ready for approval.

CHANGELOG.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with responses to your comments

Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie A few questions and comments before approval!

Copy link
Contributor

@fivetran-avinash fivetran-avinash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-jamie fivetran-jamie merged commit 601066e into main Jan 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants