-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature union schemas #55
Conversation
…bt_mixpanel into feature_union_schemas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie this looks really good! I have a few change requests, but generally the code looks great and tested on the various iterations and didn't see any issues! Once these comments are addressed this should be ready for approval.
integration_tests/tests/consistency/row_comparisons/consistency_daily_events.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with responses to your comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie A few questions and comments before approval!
Co-authored-by: Avinash Kunnath <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Overview
This PR will address the following Issue/Feature:
#52 by merging in and adding to #53
This PR will result in the following new package version:
v0.11.0
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature Update: Run Package on Unioned Connectors
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
devprodtest_incremental passes both steps
If you had to summarize this PR in an emoji, which would it be?
🥣