Apply suggestions from code review

Co-authored-by: Joe Markiewicz <[email protected]>
fivetran · Jul 29, 2024 · 02a89a1 · 02a89a1
1 parent f158894
commit 02a89a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/integration_tests/tests/consistency/row_comparisons/consistency_event.sql b/integration_tests/tests/consistency/row_comparisons/consistency_event.sql
@@ -2,15 +2,17 @@
     tags="fivetran_validations",
     enabled=var('fivetran_validation_tests_enabled', false)
 ) }}
+{% set exclude_fields = ["properties", 'event_properties'] %}
+{% set fields = dbt_utils.star(from=ref('mixpanel__event'), except=exclude_fields) %}
 
 -- this test ensures the daily_activity end model matches the prior version
 with prod as (
-    select *
+    select {{ fields }}
     from {{ target.schema }}_mixpanel_prod.mixpanel__event
 ),
 
 dev as (
-    select *
+    select {{ fields }}
     from {{ target.schema }}_mixpanel_dev.mixpanel__event
 ),
 

diff --git a/integration_tests/tests/consistency/row_comparisons/consistency_sessions.sql b/integration_tests/tests/consistency/row_comparisons/consistency_sessions.sql
@@ -2,15 +2,17 @@
     tags="fivetran_validations",
     enabled=var('fivetran_validation_tests_enabled', false)
 ) }}
+{% set exclude_fields = ["event_frequencies"] %}
+{% set fields = dbt_utils.star(from=ref('mixpanel__sessions'), except=exclude_fields) %}
 
 -- this test ensures the daily_activity end model matches the prior version
 with prod as (
-    select *
+    select {{ fields }}
     from {{ target.schema }}_mixpanel_prod.mixpanel__sessions
 ),
 
 dev as (
-    select *
+    select {{ fields }}
     from {{ target.schema }}_mixpanel_dev.mixpanel__sessions
 ),