-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nov 2024 schema #32
base: main
Are you sure you want to change the base?
Nov 2024 schema #32
Conversation
distinct * | ||
from reporting_grain_combined | ||
-- pre-reporting grain: unions all unique dimension values | ||
pre_reporting_grain as ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, I know we discussed doing full outer joins, but after looking into it, I realized it could pose a risk of losing records depending on what table is being used in the join, as explained by here. The alternative is to do a coalesce in the join key, but that may be clunky especially with more than 3 ctes being joined. Therefore I decided to do this union all - then dedupe method. This was also the method in the old version of these models too.
…sistency test, update changelog
PR Overview
This PR will address the following Issue/Feature: #28
This PR will result in the following new package version: v0.5.0
Schema changes from Nov 2024
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
to be completed
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃