Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nov 2024 schema #32

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Nov 2024 schema #32

wants to merge 20 commits into from

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Jan 31, 2025

PR Overview

This PR will address the following Issue/Feature: #28

This PR will result in the following new package version: v0.5.0

Schema changes from Nov 2024

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

to be completed

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

If you had to summarize this PR in an emoji, which would it be?

💃

distinct *
from reporting_grain_combined
-- pre-reporting grain: unions all unique dimension values
pre_reporting_grain as (
Copy link
Contributor Author

@fivetran-reneeli fivetran-reneeli Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, I know we discussed doing full outer joins, but after looking into it, I realized it could pose a risk of losing records depending on what table is being used in the join, as explained by here. The alternative is to do a coalesce in the join key, but that may be clunky especially with more than 3 ctes being joined. Therefore I decided to do this union all - then dedupe method. This was also the method in the old version of these models too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant