Feature: Union schema compatibility #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Jul 19, 2024
There was a problem hiding this comment.
@fivetran-catfritz great work on this PR! I just have a few small requests before approving this PR. Let me know if you have any questions. Thanks!
integration_tests/tests/integrity/integrity_territory_report.sql
Outdated
Show resolved
Hide resolved
packages.yml
Outdated
Comment on lines
2
to
6
| # version: [">=0.3.0", "<0.4.0"] | ||
| - git: https://github.com/fivetran/dbt_apple_store_source.git | ||
| revision: MagicBot/add-union-schema | ||
| warn-unpinned: false |
There was a problem hiding this comment.
Reminder to swap before merge
There was a problem hiding this comment.
@fivetran-joemarkiewicz I have updated, and this is ready for re-review!
fivetran-joemarkiewicz
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Confirm the following files were correctly updated automatically:
country_codes,source_relationwould not be includedwindow functions (partition by)Manual updates:
source_relationto downstream models if necessarysource_relationin unique-combination-of-cols if necessaryValidation:
Consistency: When not using unioning, tests in the folder
tests/consistency/row_countspassIntegrity: I was able to write 1 integrity test for
app_store_territory_source_type_reportsince there wasn't much aggregation from the source, but the others were too complex to write a meaningful test.Spot check with seed data for unioning:
Also: