Skip to content

Commit

Permalink
Merge pull request #46 from fivetran/bugfix/google-ads-update
Browse files Browse the repository at this point in the history
Bugfix/google ads update
  • Loading branch information
fivetran-joemarkiewicz authored Feb 24, 2022
2 parents fda2aa4 + 554b6f1 commit 4f6b147
Show file tree
Hide file tree
Showing 10 changed files with 41 additions and 219 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# dbt_ad_reporting v0.7.0
## 🚨 Breaking Changes 🚨
- The Google Ads dependency has been updated to now reference the latest version of the `dbt_google_ads` package (v0.6.0). This version of the package incorporates new and modified tables within the `Google Ads API` version of the connector. For more information, refer to the relevant [dbt_google_ads](https://github.com/fivetran/dbt_google_ads_source/releases/tag/v0.6.0) and [dbt_google_ads_source](https://github.com/fivetran/dbt_google_ads/releases/tag/v0.6.0) v0.6.0 release notes.

# dbt_ad_reporting v0.6.0
TikTok Ads has been added as a dependency and is enabled by default. Be sure to disable the models via the README if you do not have a TikTok Ads connector.

Expand Down Expand Up @@ -25,4 +29,4 @@ TikTok Ads has been added as a dependency and is enabled by default. Be sure to
- @csoule1622 ([#30](https://github.com/fivetran/dbt_ad_reporting/pull/30))

# dbt_ad_reporting v0.1.0 -> v0.5.0
Refer to the relevant release notes on the Github repository for specific details for the previous releases. Thank you!
Refer to the relevant release notes on the Github repository for specific details for the previous releases. Thank you!
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Include in your `packages.yml`
```yaml
packages:
- package: fivetran/ad_reporting
version: [">=0.6.0", "<0.7.0"]
version: [">=0.7.0", "<0.8.0"]

```

Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'ad_reporting'
version: '0.6.0'
version: '0.7.0'
config-version: 2

require-dbt-version: [">=1.0.0", "<2.0.0"]
Expand Down
13 changes: 3 additions & 10 deletions integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'ad_reporting_integration_tests'
version: '0.6.0'
version: '0.7.0'
profile: 'integration_tests'
config-version: 2

Expand All @@ -12,12 +12,11 @@ vars:
google_ads__final_url_performance: "{{ ref('google_ads_final_url_performance_data') }}"
google_ads__click_performance: "{{ ref('google_ads_click_performance_data') }}"
google_ads__criteria_performance: "{{ ref('google_ads_criteria_performance_data') }}"
google_ads__ad_final_url_history: "{{ ref('google_ads_ad_final_url_history_data') }}"
google_ads__ad_stats: "{{ ref('google_ads_ad_stats_data') }}"
google_ads__ad_history: "{{ ref('google_ads_ad_history_data') }}"
google_ads__ad_group_history: "{{ ref('google_ads_ad_group_history_data') }}"
google_ads__campaign_history: "{{ ref('google_ads_campaign_history_data') }}"
google_ads__account: "{{ ref('google_ads_account_data') }}"
google_ads__account_history: "{{ ref('google_ads_account_history_data') }}"

microsoft_ads_source:
account_history: "{{ ref('microsoft_ads_account_history_data') }}"
Expand Down Expand Up @@ -181,10 +180,6 @@ seeds:
id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
base_campaign_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
customer_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
google_ads_ad_final_url_history_data:
+column_types:
ad_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
ad_group_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
google_ads_ad_group_history_data:
+column_types:
id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
Expand All @@ -195,8 +190,6 @@ seeds:
+column_types:
id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
ad_group_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
base_adgroup_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"
base_campaign_id: "{{ 'INT64' if target.type == 'bigquery' else 'bigint' }}"

### Facebook Seeds

Expand Down Expand Up @@ -235,4 +228,4 @@ seeds:

snapchat_ad_hourly_report_data:
+column_types:
date: timestamp
date: timestamp
2 changes: 1 addition & 1 deletion integration_tests/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dbt-snowflake==1.0.0
dbt-bigquery==1.0.0
dbt-redshift==1.0.0
dbt-postgres==1.0.0
dbt-postgres==1.0.3
dbt-spark==1.0.0
dbt-spark[PyHive]==1.0.0
2 changes: 0 additions & 2 deletions integration_tests/seeds/google_ads_account_data.csv

This file was deleted.

2 changes: 2 additions & 0 deletions integration_tests/seeds/google_ads_account_history_data.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
id,updated_at,_fivetran_synced,auto_tagging_enabled,currency_code,descriptive_name,final_url_suffix,hidden,manager,manager_customer_id,optimization_score,pay_per_conversion_eligibility_failure_reasons,test_account,time_zone,tracking_url_template
2121450128,2022-02-01 2:20:51,2022-02-01 2:20:52,TRUE,USD,,FALSE,FALSE,,0.5,[],FALSE,America/Los_Angeles,,
101 changes: 0 additions & 101 deletions integration_tests/seeds/google_ads_ad_final_url_history_data.csv

This file was deleted.

Loading

0 comments on commit 4f6b147

Please sign in to comment.