Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added few features (androidx) & SD card file selection crash fix #41

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

jibon57
Copy link

@jibon57 jibon57 commented Sep 8, 2018

Thanks for your excellent library. I am using your library in one of my NativeScript plugin. I have added following features:

  • EXTRA_VIDEO_QUALITY (For setting quality of video)
  • EXTRA_DURATION_LIMIT (For setting video duration)
  • EXTRA_MAX_BYTES (For setting recorded file size in bytes)
  • androidx support

Fix:

  • SD card file selection crash.

Please merge if you think this will be helpful :)

* EXTRA_VIDEO_QUALITY
* EXTRA_DURATION_LIMIT
* EXTRA_MAX_BYTES
When you will select files from SD card the app will get crash but this patch will fix it.

java.lang.IllegalArgumentException: Failed to find configured root that contains...
@jibon57 jibon57 changed the title Added few features Added few features & SD card file selection crash fix Sep 12, 2018
@jibon57 jibon57 changed the title Added few features & SD card file selection crash fix Added few features (androidx) & SD card file selection crash fix Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants