feat(i18n): Ajout complet de la localisation en Français Québécois (f… #107264
Conversation
|
Thank you for your pull request. This pull request contains changes in files which requires review. The following files were changed:
|
README.md
Outdated
| <kbd>[<img title="Mongolian" alt="Mongolian" src="https://cdn.statically.io/flags/mn.svg" width="22">](docs/translations/README.mn.md)</kbd> | ||
| <kbd>[<img title="Tounsi" alt="Tounsi" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/tn.svg" width="22">](docs/translations/README.tn.md)</kbd> | ||
| <kbd>[<img title="Lingala" alt="Lingala" src="https://cdn.statically.io/gh/hjnilsson/country-flags/master/svg/cd.svg" width="22">](docs/translations/README.ln.md)</kbd> | ||
| <kbd>[<img title="Québécois (Français)" alt="Québécois" src="https://upload.wikimedia.org/wikipedia/commons/thumb/5/5f/Flag_of_Quebec.svg/320px-Flag_of_Quebec.svg.png" width="22">](docs/cli-tool-tutorials/translations/github-cli-tutorials-quebecois.md)</kbd> |
There was a problem hiding this comment.
Hi , i am a native Quebec french speaker , and i changed the translate file , Thank you for your return.
| [](https://www.codetriage.com/roshanjossey/first-contributions) | ||
|
|
||
|
|
||
| # Premières Contributions (Français Québécois) |
There was a problem hiding this comment.
Hello @Oue-h, README.qc.md and github-cli-tutorials-quebecois.md has the same content. It looks like both are translation of github-cli-tutorial.md. Can you please translate main README.md and put quebec translation in this file?
docs/translations/README.fr-ca.md
Outdated
| @@ -0,0 +1,101 @@ | |||
| [](https://github.com/ellerbrock/open-source-badges/) | |||
There was a problem hiding this comment.
If I understand correctly, official code for Quebec is qc, but language code should be slightly different.
Since I didn't found ISO code for Quebec french language specifically, I would say you can use either fr-u-sd-caqc or fr-ca. Using second one, you don't specifically distinguish Québécois from Acadian or Newfoundland french.
@Oue-h do you have any expirience with the proper code for this language?
@Roshanjossey what do you think we should use for the code, regarding #105867?
There was a problem hiding this comment.
Hi ,
Thank you for the guidance on the language codes and the content mix-up. I appreciate you catching that!
I have implemented the corrections and pushed a new commit to the PR:
- Language Code Standardized: I am using
fr-ca(French Canadian) as the technical language code. - File Naming: The main documentation file is now named
README.fr-ca.md. - Content Corrected: The content of
README.fr-ca.mdis now the accurate translation of the main projectREADME.md. - Consistency: The CLI tutorial file has also been renamed to
github-cli-tutorials-fr-ca.mdfor consistency. - Link Updated: The link in the root
README.mdis updated to point to the newREADME.fr-ca.mdfile. - CONTRIBUTORS: i add my name to the file already.
Please let me know if there are any further adjustments needed. Thank you again for your help in finalizing my first contribution!
There was a problem hiding this comment.
Hello @Oue-h,
Link Updated: The link in the root README.md is updated to point to the new README.fr-ca.md file.
It doesn't look like that, both files are still the same as github-cli-tutorial.md.
CONTRIBUTORS: i add my name to the file already.
You've changed Contributors.md, but not the CONTRIBUTING.md. Second one contains a list of language maintainers/translators. There is an open discussion to improve the CONTRIBUTING.md file in #106829.
There was a problem hiding this comment.
Hi , I corrected everything , i think its all done , hopefully !!
thank you for your patience !!!
|
Hi @Oue-h, can you maybe add yourself to the CONTRIBUTING.md. Doing that, everyone can find you and ask for help about future Quebec translations. |
docs/translations/README.fr-ca.md
Outdated
|
|
||
| La branche main de votre dépôt forker ne subira pas de modification. Pour que votre dépôt soit synchronisé avec le mien, suivez les étapes suivantes. | ||
|
|
||
| ## Gardez votre embranchement synchronisé avec ce répertoire |
There was a problem hiding this comment.
Hello @Oue-h, I think this part doesn't exist in the main README. Can you please check it once more?
There was a problem hiding this comment.
it's done , thank you for your patience !
rammba
left a comment
rammba
left a comment
There was a problem hiding this comment.
@Oue-h thanks for the contribution and patience in the review. I think this translation is not ready to be merged.
However, GitHub says that you have conflicts with the master branch. Can you merge latest master into your branch, please?
rammba
left a comment
rammba
left a comment
There was a problem hiding this comment.
@Oue-h thanks for the contribution and translation.
@Roshanjossey can you please merge this PR?
2 participants
Bonjour,
J'aimerais ajouter la localisation en français québécois (fr-CA) au dépôt, car cette langue n'était pas encore disponible dans la liste des traductions.
Cette PR comprend :
*L'ajout du nom et address du Contibutor (Contributors.md)
J'ai fait une adaptation terminologique (ex: "pousser" au lieu de "envoyer" pour push) pour mieux correspondre au jargon technique utilisé au Québec.
Merci de considérer mon ajout !