-
-
Notifications
You must be signed in to change notification settings - Fork 95.2k
Improve Traditional Chinese translation in README.zh-tw.md #106718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Could you please review @Sharl0tteIsTaken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are good changes, including (the detailed reasons will not be listed here):
- (L34)
帳戶名下->GitHub帳號下 - (L83)
喜歡的->偏好的 - (L95)
commit(提交)->提交 - (L120)
去->參考and密匙->金鑰
There are some needed discussion:
- (L7) The project introduction should use either spoken (colloquial) or written language (colloquial is used prior to this proposed commit), how to translate project
- (L26) The translation of you (
你/妳) - (L28) The translation of the word terminal (
命令列or指令列) - (L69) & (L114) If the colon at the end of sentence is necessary
- (L89) & (L124) The former translator uses a relatively colloquial tone, which is evident from the very beginning of the README (the introduction part).
- (L120) The translation of configuring (
配置) - (L157) The words selected for translation
- (L167) Project supporter is not on the English README, but present in the Chinese translation (Simplified and Traditional)
There are a lot of either is good, not going to list it all here.
There are some needed changes:
- (L11) Proposed commit would break hyperlink
- (L71) Git is capitalized in the English README
(Edit)
Updated the format.
| # 第一次參與開源 | ||
|
|
||
| 萬事起頭難。特別是和其他人合作時,犯錯格外令人不舒服。不過,開源的本質就是和其他人合作。我們希望為初學者帶來一個簡單的方法來學習及參與開源項目。 | ||
| 這份專案重點在引導新手踏入開源的世界!我們希望能為初學者介紹簡單的方法開始學習如何貢獻,如果你也想踏入開源軟體的世界,現在就加入我們一起開始吧!只需要按照以下簡單的步驟:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project introduction in this translated version differs slightly from the original English README, but with the same meaning (albeit it's longer). If I understand correctly this is translated to Traditional Chinese from README.zh-cn-md (the Simplified Chinese translated version). I think either is good.
README.zh-tw.md introduction translated back to English:
Getting started is always the hardest part. Especially when collaborating with others, making mistakes is particularly unpleasant. However, the core of open source is collaboration. We hope to provide beginners with a simple way to learn and participate in open source projects.
Reading articles and watching tutorials can be helpful. But what could be better than actual practice without messing anything up? This project aims to guide beginners and simplify the process for them to participate in open source. Remember: with easier process, brings more effective learning. If you want to make your first contribution, just follow these simple steps. Promise you, it will be fun :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional opinion, the use of:
如果你也想踏入開源
軟體的世界 (If you also want to step into the world of open sourcesoftware)
Should be:
如果你也想踏入開源
項目的世界 (If you also want to step into the world of open sourceproject)
Also, we can discuss how to translated project (maybe in another issue), both 專案 and 項目 were used in this translation.
| 閱讀文章和觀看教學會有所幫助。不過,有什麼方法能比在不會弄亂任何東西的情況下,實際動手做來得更好?本項目旨在指導初學者及簡化初學者參與開源的方式。記住:過程越輕鬆,學習效益越高。如果妳/你想要做出第一次貢獻,只需按照以下簡單步驟操作即可。跟你保證,這會很好玩 :) | ||
|
|
||
| _如果你不喜歡使用指令列,[這裡有使用圖形界面工具的教學。](#使用其他工具的教學)_ | ||
| _如果你不喜歡使用指令列,[這裡有使用圖形界面工具的教學]。(#使用其他工具的教學)_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change would break hyperlink, and I think it's fine for hyperlink to include the period or not.
| <img align="right" width="300" src="https://firstcontributions.github.io/assets/Readme/clone.png" alt="複製本儲存庫" /> | ||
|
|
||
| 接下來,將分叉後的儲存庫複製到你/妳的電腦上。前往你/妳的GitHub帳號,打開分叉到帳號下的儲存庫,點選圖示中的綠色按鈕,接著在SSH分頁上點選*複製到剪貼簿*按鈕(將儲存庫網址複製下來)。 | ||
| 接下來,將分叉(Fork)後的儲存庫複製到你/妳的電腦上。前往你的GitHub帳號,打開分叉(Fork)到帳號下的儲存庫,點選圖示中的綠色按鈕,接著在SSH分頁上點選*複製到剪貼簿*按鈕(將儲存庫網址複製下來)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is unnecessary to add the translation for git terminology in the paragraph, as when readers encounter unfamiliar terminology, they will realise they have skipped something (the title of this section). Either is good.
I don't think it is a good idea to remove the 你/妳 part. 你/妳 is translated to you, and the Chinese word you has gender distinctions. Though in Chinese, 你 can represent both genders (妳 can only represent female), but I think it's best to kept it, since it already exists in the translated version, I am with the original translator on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same review is omitted below (the 你/妳 part).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same review is omitted below (the add the translation for git terminology in the paragraph part, e.g. 分叉 -> 分叉(Fork)).
| 接下來,將分叉(Fork)後的儲存庫複製到你/妳的電腦上。前往你的GitHub帳號,打開分叉(Fork)到帳號下的儲存庫,點選圖示中的綠色按鈕,接著在SSH分頁上點選*複製到剪貼簿*按鈕(將儲存庫網址複製下來)。 | ||
|
|
||
| 隨後打開命令列視窗,輸入如下 git 命令: | ||
| 隨後打開指令列視窗,輸入如下 git 指令: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the translation of the word terminal I've done some digging, I think this repo with translated version of Pro Git 2, is a good reference. In the repo, 命令, 指令, 命令列 and 指令列 were all used, with 命令 and 命令列 being used more frequently. Prior to this proposed commit, this is also the case for the Traditional Chinese translated verion, 指令 is used in 指令列 in line 11 (here).
Another good reference wiki used 命令 as well. Because my major is not CSIE (Computer Science and Information Engineering), either is good for me.
@ruryu Could you please provide some reference materials? Textbooks, lecture slides, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same review is omitted below (translation of the word terminal part).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the translation of the word terminal I've done some digging, I think this repo with translated version of Pro Git 2, is a good reference. In the repo, 命令, 指令, 命令列 and 指令列 were all used, with 命令 and 命令列 being used more frequently. Prior to this proposed commit, this is also the case for the Traditional Chinese translated verion, 指令 is used in 指令列 in line 11 (here).
I felt like the previous review isn't clear enough for English speaker, I will elaborate here:
terminal can be translated to 命令列 or 指令列
command can be translated to 命令 or 指令
All four translation is used in the repo (translated version of Pro Git 2), so either use is good for me.
In README.zh-tw.md mostly translate terminal as 命令列. However, there is also one instance where 指令列 is used (L11), but command is only translated as 命令.
Either is good for me, but based on my research I think 命令 and 命令列 are more appropriate here, unless reference materials are provided.
| <img align="right" width="300" src="https://firstcontributions.github.io/assets/Readme/copy-to-clipboard.png" alt="複製連結到剪貼簿" /> | ||
|
|
||
| 譬如: | ||
| 範例: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either is good, the meaning is the same.
| remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information. | ||
| fatal: Authentication failed for 'https://github.com/<your-username>/first-contributions.git/'</pre> | ||
| 去 [GitHub's tutorial](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account) 學習如何生成新的 SSH 密匙以及配置。 | ||
| 參考 [GitHub's tutorial](https://docs.github.com/en/authentication/connecting-to-github-with-ssh/adding-a-new-ssh-key-to-your-github-account) 學習如何生成新的 SSH 金鑰以及配置。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, with more natural Taiwanese wording.
參考(reference) -> 去(go to)
密匙(key) -> 金鑰(key)
We can discuss the wording of 配置 (configuring) to see if it's appropriate for this situation. @ruryu What do you think?
In the English README:
Go to GitHub's tutorial on generating and configuring an SSH key to your account.
| 此外,你可能需要執行 'git remote -v' 來檢查遠端儲存庫的URL。 | ||
|
|
||
| 如果看起來與這樣有一點相似: | ||
| 如果出現下面這項訊息: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果看起來與這樣有一點相似 and 如果出現下面這項訊息 are colloquial and written version of If it looks anything like this. Either is good.
如果看起來與這樣有一點相似 -> If it looks a bit similar to this
如果出現下面這項訊息 -> If the following message appears
| 在[這個網站](https://firstcontributions.github.io/#social-share)慶祝你的貢獻並跟朋友及追隨者分享。 | ||
|
|
||
| 如果你想要更多練習,請看 [code contributions](https://github.com/roshanjossey/code-contributions)。 | ||
| 如果想要更多練習,請看 [code contributions](https://github.com/roshanjossey/code-contributions)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, either is good, I don't think removing the subject is necessary tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subject being 你 (you) in L155.
| 如果想要更多練習,請看 [code contributions](https://github.com/roshanjossey/code-contributions)。 | ||
|
|
||
| 現在就動手為其他專案貢獻你/妳的心力。我們整理了一個清單,裡面的專案都有簡單的議題可以著手。[去看看吧!](https://firstcontributions.github.io/#project-list) | ||
| 現在就動手為其他專案貢獻你的力量。我們整理了一個清單,裡面的專案都有簡單的問題可以著手。[去看看吧!](https://firstcontributions.github.io/#project-list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
心力 is similar to mental and physical efforts
力量 is similar to power, strength
議題 is similar to 問題, both can translated to issue, but 議題 has an additional element of discussion.
Either is good, but I prefer the former in both cases.
| | [GitHub Desktop](../gui-tool-tutorials/github-desktop-tutorial.md) | [Visual Studio 2017](../gui-tool-tutorials/github-windows-vs2017-tutorial.md) | [GitKraken](../gui-tool-tutorials/gitkraken-tutorial.md) | [Visual Studio Code](../gui-tool-tutorials/github-windows-vs-code-tutorial.md) | [Atlassian Sourcetree](../gui-tool-tutorials/sourcetree-macos-tutorial.md) | [IntelliJ IDEA](../gui-tool-tutorials/github-windows-intellij-tutorial.md) | | ||
|
|
||
| <p>項目支持者:</p> | ||
| <p>專案貢獻者:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not in the English README, as I said above I think this is from README.zh-cn.md, what is used there is 项目支持者 (project supporter or sponsor) not 專案貢獻者 (project contributor).
|
Hello @ruryu. Thank you for making this PR! ✨ Hello @Roshanjossey, Thank both of you in advance! 🎉 |
|
Thank you for such a detailed review @Sharl0tteIsTaken. I really appreciate the time, effort and attention you put into it. Don't worry about taking time. There's no pressure from my side. For other issues or pull requests that needs my input, please tag me. If you think a change doesn't make sense, you can close it yourself. |
|
Hello @Roshanjossey, thank you for your reply and affirmation. 🙏 This PR does propose some changes needed your input:
What are your thoughts on these? |
Let's keep the current version. I think it's good to be a little informal.
It's best to keep it gender neutral. Let's keep the current version.
No, this sponsorship ended. We don't have to add it now. |
|
Hello @Roshanjossey, thanks for the response. 🙏 I will make changes accordingly, the sponsorship section will be removed, unmentioned reviews will be changed after further discussion with @ruryu. |
Summary
This pull request improves the Traditional Chinese translation in
README.zh-tw.md.Changes
Notes
Although this repository is mainly for practicing first-time contributions,
this PR aims to genuinely improve the documentation so that future contributors using the Traditional Chinese version can follow it more clearly.