Initial approach to a Firmata SPI implementation #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaldron
reviewed
Jan 16, 2017
|
|
||
| bool SPIFirmata::handlePinMode(uint8_t pin, int mode) | ||
| { | ||
| // There is no reason for a user to manually set the SPI pin modes |
soundanalogous
commented
Jan 16, 2017
utility/SPIFirmata.cpp
Outdated
| pinMode(mCsPin, OUTPUT); | ||
|
|
||
| if (argv[10] != END_SYSEX) { | ||
| mCsActiveState = argv[10]; |
There was a problem hiding this comment.
Need to ensure that argv[10] is a valid value (0 or 1)
There was a problem hiding this comment.
fallback to default (SPI_CS_ACTIVE_LOW) if invalid
Open
soundanalogous
force-pushed
the
spi-alpha
branch
from
fe2a5a8 to
7bdefb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial approach to Firmata SPI support. Consider this a prototype for now. The draft proposal that this implementation is based on is available here: https://github.com/firmata/protocol/blob/master/proposals/spi-proposal.md.
SPI is a difficult protocol to implement in a generic way. The idea with this prototype implementation is to get it out there and have people start testing with various SPI devices to see where it falls short.
A prototype Firmata client implementation is also being explored for firmata.js: https://github.com/firmata/firmata.js/compare/spi-alpha. You can use that to test devices or use it as an example for testing in other programming environments.
Note that both the Arduino implementation and the firmata.js are still changing, but should be stable enough to checkout and test with (just be sure to checkout both at the same time as I'm pushing updates simultaneously).