Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Event based refactor #17

Closed
wants to merge 33 commits into from
Closed

WIP: Event based refactor #17

wants to merge 33 commits into from

Conversation

adam-h
Copy link
Collaborator

@adam-h adam-h commented Oct 30, 2017 •
edited
Loading

Continuation of #11

This is a WIP of an event based interface to Firehose, replacing the current callback interface completely.

@nguyenj What do you think about this?

TODO:

  • Multiplexed transports refactored
  • Add multiplex option to Connection (rather than having a MultiplexedConnection
  • Add a whole slew of tests (only part of WebSocketTransport is done so far)
  • Define what exactly each event means
    • Needs more work around 'Closed', 'Failed', 'Disconnected' and ways to distinguish errors which are fatal, which will try reconnecting and which were expected (we asked it to close nicely)

nguyenj and others added 30 commits August 24, 2017 16:57
@nguyenj
Upgrade webpack to v3
e0e8b6b
@nguyenj
Update webpack.config.js to work with webpack v3
a535cbb
@nguyenj
Move non-browser related dependencies into the devDependencies
aea5960
@nguyenj
Add jQuery as a peer dependency
3e9b99f
@nguyenj
Enable webpack to build lib to UMD format
35757dd
@nguyenj
Use dist file for testing
12d8aa7
@nguyenj
Let webpack handle codename interpolation
c3d2652
@nguyenj
Pin jasmine at 2.4.1
2518956
@nguyenj
Npm package only the dist files
ebdbd2e
@nguyenj
Remove unneccessary JSON.stringify call
61ce1e5
@nguyenj
Revert "Remove unneccessary JSON.stringify call"
e866c4f 
This reverts commit 61ce1e5.

Without JSON.stringify, the variables being replaced ends up as a number
type or a variable rather than a string type value.
@nguyenj
Update webpack with babel
1d49370
@nguyenj
Decaffeinate
06fbf47
@nguyenj
Remove all coffeescript
043b4f2
@nguyenj
Use native promise
a58240b
@nguyenj
Add xhr npm package
3ac1d85
@nguyenj
Replace ajax calls with xhr calls
09e0904
@nguyenj
Initial conversion of typescript
5a80efa
@adam-h
Fix majority of typescript warnings
9a93c94
@adam-h
Fix all non-browser based warnings
8c133db 
Alos cleanup some of the decaffeinate stuff
@nguyenj
Fix document and window global ts errors
42f3154
@nguyenj
Update tsconfig
2f0563c
@nguyenj
Fix promise typescript errors
48a24a4
@adam-h
Remove unnecessary directory
fdf0caa
@adam-h
WIP Upgrade to event based model
c344d08 
WebSocketTransport is upgraded and working with a basic manual test, needs automated tests

LongPollTransport is mostly upgraded and needs testing
@adam-h
WIP Long poll
bd19ab1
@adam-h
Move typedefs into dir
4669780
@adam-h
Move multiplex files into separate uncompiled dir to clear errors whi…
b07bcee 
…le working
@adam-h
Refactor transport
29e85cb
@adam-h
WIP specs
1371e57
@nguyenj
Copy link
Contributor

nguyenj commented Oct 30, 2017

@adam-h looking goooood.

@adam-h
Fix and improve tests
71129c6
@adam-h
Add debug script
2d0cc7f 
Lets you use chrome://inspect with node8
@steel
Copy link
Member

steel commented Nov 7, 2017

This is a good start. I'd advocate to include these in this refactor.
#16
#15

@adam-h
Copy link
Collaborator Author

adam-h commented Nov 8, 2017

@steel Definately #15 , I'm not sure about #16 - started a chat there

@nguyenj nguyenj force-pushed the webpackv3 branch 3 times, most recently from 4601a4e to 040df7b Compare January 23, 2018 01:35
@adam-h adam-h closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adam-h @nguyenj @steel