Use appropriate user in CI to avoid permissions errors on later runs #4545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JHopeCollins don't bother reviewing. Needs more thought. |
connorjward
commented
Sep 5, 2025
Comment on lines
+16
to
+25
|
|
||
| # UNDO ME | ||
| docker: | ||
| name: Build developer Docker containers | ||
| uses: ./.github/workflows/docker.yml | ||
| with: | ||
| tag: connorjwardtest-dev-${{ github.base_ref }} | ||
| branch: ${{ github.base_ref }} | ||
| build_dev: true | ||
| secrets: inherit |
There was a problem hiding this comment.
Suggested change
| # UNDO ME | |
| docker: | |
| name: Build developer Docker containers | |
| uses: ./.github/workflows/docker.yml | |
| with: | |
| tag: connorjwardtest-dev-${{ github.base_ref }} | |
| branch: ${{ github.base_ref }} | |
| build_dev: true | |
| secrets: inherit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the permissions issues that we saw building Docker images on CI.
The issue was that the regular CI runs are run in a Docker container as the root user and this means that if a job is cancelled then a bunch of files are left behind that are owned by
root. If we subsequently build a Docker image on the same runner we would crash because that workflow is run as an unprivileged user.I tried to make the regular CI runs use an unprivileged user but I don't think that it is possible. Instead the solution I've found here is to build the Docker images inside another container, and hence as root.