Warn unused options #3999
Draft
Warn unused options #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
commented
Jan 28, 2025
|
|
dham
commented
Jan 28, 2025
Co-authored-by: Connor Ward <[email protected]>
connorjward
force-pushed
the
warn_unused_options
branch
from
2a4897b to
00b9b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause a warning message to be logged for solver options that are unused.
This needs us to update to PETSc main, which depends on us fixing #3998 .
This is currently rebased on
dham/petsc_merge_upstream(#3997)