Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assembly of split forms with subdomain ids #3993

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix assembly of split forms with subdomain ids #3993

merged 3 commits into from
Jan 24, 2025
+28 −5

Conversation

pbrubeck
Copy link
Contributor

Description

Fixes #3990

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/split-subdomain-ids branch from d0881e4 to c57ce04 Compare January 24, 2025 11:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8084 ran6520 passed1564 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real7762 ran7124 passed638 skipped0 failed

@pbrubeck pbrubeck force-pushed the pbrubeck/fix/split-subdomain-ids branch from c57ce04 to 7273666 Compare January 24, 2025 11:29
@pbrubeck pbrubeck force-pushed the pbrubeck/fix/split-subdomain-ids branch from 7273666 to a4e6cb5 Compare January 24, 2025 11:53
@pbrubeck pbrubeck requested a review from ksagiyam January 24, 2025 15:15
ksagiyam
ksagiyam requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ksagiyam ksagiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need a change in l.1378 of assemble.py.

tests/firedrake/regression/test_assemble.py Outdated Show resolved Hide resolved
This was referenced Jan 24, 2025
Closed
Merged
ksagiyam
ksagiyam requested changes Jan 24, 2025
View reviewed changes
firedrake/assemble.py Outdated Show resolved Hide resolved
@ksagiyam ksagiyam enabled auto-merge (squash) January 24, 2025 16:43
@ksagiyam ksagiyam merged commit 58f3d6f into master Jan 24, 2025
20 checks passed
@ksagiyam ksagiyam deleted the pbrubeck/fix/split-subdomain-ids branch January 24, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksagiyam ksagiyam ksagiyam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: incorrect assembly of mixed Jacobian with subdomain restricted term
2 participants
@pbrubeck @ksagiyam