Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a different approach to parallel tests #3978

Merged
merged 23 commits into from
Jan 21, 2025

Conversation

connorjward
Copy link
Contributor

@connorjward connorjward commented Jan 16, 2025

Description

Builds on #3385 but uses GNU parallel instead of Jack's mpispawn library.

JHopeCollins and others added 11 commits January 9, 2025 19:24
…tch (#3961)

* fix test for mixed-ness in Function.sub, and fix Cofunction.sub to match

* allow FunctionSpace.sub to take negative indices

* cofunc docstring
* Preserve  default mesh name after Netgen mesh creation to avoid checkpointing errors

* Ensure consistent handling of mesh and topology names for Netgen and non-Netgen meshes
…3875)

* Add functionality to print patch statistics in ASMStarPC and friends


---------

Co-authored-by: Pablo Brubeck <[email protected]>
* Restricted Cofunction RHS

* Fix BCs on Cofunction

* LinearSolver: check function spaces

* assemble(form, zero_bc_nodes=True) as default

* Fix FunctionAssignBlock

* Allow Cofunction.assign take in constants

* remove BaseFormAssembler test

* only supply relevant kwargs to OneFormAssembler

* Only interpolate the residual, not every cofunction in the RHS

* Fix tests

* Fix adjoint utils

* More robust test for (unrestricted) Cofunction RHS

* Replace empty Jacobians with ZeroBaseForm

* Do not split off-diagonal blocks if we only want the diagonal

* Zero-simplify slate Tensors

* set bcs directly on diagonal Cofunction

* ImplicitMatrixContext: handle empty action

* Only extract constants referenced in the kernel

* Adjoint: only skip expand_derivatives if necessary

* EquationBC: do not reconstruct empty Forms

* lower degree for EquationBC tests

* Update .github/workflows/build.yml
Copy link

github-actions bot commented Jan 16, 2025

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8075 ran6514 passed1561 skipped0 failed

Copy link

github-actions bot commented Jan 16, 2025

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real7989 ran7279 passed710 skipped0 failed

Not happy but this is only happening on CI, not locally.
@connorjward connorjward mentioned this pull request Jan 21, 2025
3 tasks
@connorjward connorjward marked this pull request as ready for review January 21, 2025 16:58
@connorjward connorjward merged commit bda45e2 into JDBetteridge/faster_tests Jan 21, 2025
19 of 20 checks passed
@connorjward connorjward deleted the connorjward/avoid-comm-spawning branch January 21, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants