Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure PETSc with --with-strict-petscerrorcode #3962

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Configure PETSc with --with-strict-petscerrorcode #3962

merged 6 commits into from
Jan 10, 2025

Conversation

connorjward
Copy link
Contributor

Description

Motivation (https://gitlab.com/petsc/petsc/-/blob/main/include/petscsystypes.h?ref_type=heads#L53):

The user can also configure PETSc with the --with-strict-petscerrorcode option to enable
compiler warnings when the returned error codes are not captured and checked. Users are
heavily encouraged to opt-in to this option, as it will become enabled by default in a
future release.

@connorjward connorjward marked this pull request as draft January 9, 2025 14:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8156 ran6682 passed1474 skipped0 failed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8162 ran7487 passed675 skipped0 failed

prj-
prj- reviewed Jan 9, 2025
View reviewed changes
tinyasm/tinyasm.cpp Outdated Show resolved Hide resolved
connorjward
connorjward commented Jan 9, 2025
View reviewed changes
tinyasm/tinyasm.cpp Outdated Show resolved Hide resolved
connorjward
connorjward commented Jan 9, 2025
View reviewed changes
tinyasm/tinyasm.cpp Outdated Show resolved Hide resolved
connorjward
connorjward commented Jan 9, 2025
View reviewed changes
tinyasm/tinyasm.cpp Outdated Show resolved Hide resolved
@connorjward connorjward marked this pull request as ready for review January 10, 2025 15:45
JHopeCollins
JHopeCollins previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks OK, nothing is sticking out at me.

@connorjward connorjward merged commit 5c6e320 into master Jan 10, 2025
16 checks passed
@connorjward connorjward deleted the connorjward/strict-petsc branch January 10, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prj- prj- prj- left review comments

@JHopeCollins JHopeCollins JHopeCollins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjward @prj- @JHopeCollins