Fieldsplit: replace empty Forms with ZeroBaseForm #3947
+196
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
from
cf743a1 to
be6a7b4
Compare
pbrubeck
changed the title
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
2 times, most recently
from
e0c7ba1 to
00b80e4
Compare
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
2 times, most recently
from
3f399e5 to
bf10f91
Compare
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
from
bf10f91 to
d82039d
Compare
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
2 times, most recently
from
730e299 to
35638df
Compare
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
from
35638df to
3d06fc5
Compare
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
from
897cd3c to
d6bb7dd
Compare
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
from
9c1c516 to
d6bb7dd
Compare
pbrubeck
force-pushed
the
pbrubeck/simplify-indexed
branch
from
d7f0a1b to
2a0c03b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the consequences of FEniCS/ufl#336, which introduces more agressive simplifications that cause empty forms to be returned when extracting a subblock that is supposed to be zero (e.g. the pressure block in Stokes).
Here empty Jacobians are replaced with ZeroBaseForm, as we require two Arguments in order for the adjoint to make sense.
The simplifications should also speed up code generation and even reduce flop counts in some cases.