Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: sync fs before checking for output file #5010

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Jan 23, 2025

It can happen that we check for the file before socat has written it in the filesystem.

Sync before checking.

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Type: Fix Indicates a fix to existing code python Pull requests that update Python code labels Jan 23, 2025
@pb8o pb8o self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (d28ef60) to head (c62923e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5010   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files         245      245           
  Lines       26697    26697           
=======================================
  Hits        22194    22194           
  Misses       4503     4503           
Flag Coverage Δ
5.10-c5n.metal 83.59% <ø> (-0.01%) ⬇️
5.10-m5n.metal 83.58% <ø> (ø)
5.10-m6a.metal 82.79% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.56% <ø> (ø)
5.10-m6i.metal 83.57% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.56% <ø> (ø)
6.1-c5n.metal 83.59% <ø> (ø)
6.1-m5n.metal 83.58% <ø> (ø)
6.1-m6a.metal 82.79% <ø> (ø)
6.1-m6g.metal 79.56% <ø> (ø)
6.1-m6i.metal 83.57% <ø> (-0.01%) ⬇️
6.1-m7g.metal 79.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o added the Status: Awaiting author Indicates that an issue or pull request requires author action label Jan 23, 2025
It can happen that we check for the file before `socat` has written it
in the filesystem.

Sync before checking.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Jan 23, 2025
@pb8o pb8o merged commit a2a3484 into firecracker-microvm:main Jan 23, 2025
8 checks passed
@pb8o pb8o deleted the fix-test-tap branch January 23, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled python Pull requests that update Python code Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants