-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(evals): Updated docs for evals #1512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this LGTM. I wonder if we need to give them a RAG flow to evaluate, esp. given that we chose 'maliciousness'.
Maliciousness is not RAG specific. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General observations:
- Informal tone is fine, but avoid "chatty". (E.g., "Now, we'll" or "Let's...")
- Avoid future tense and passive voice
- Always break lines at <= 80 cols
Please review second doc (plugin) and make similar edits, based on what I've done in the first doc.
Part of #985
Checklist (if applicable):