put workflow_run success check in braces

firebase · Nov 4, 2024 · 42936e3 · 42936e3
1 parent 87a8522
commit 42936e3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/check-pkg-paths.yml b/.github/workflows/check-pkg-paths.yml
@@ -23,7 +23,7 @@ on:
 
 jobs:
   test:
-    if: ${{ github.event.workflow_run.conclusion }} == 'success'
+    if: ${{ github.event.workflow_run.conclusion == 'success'}}
     name: Test Package Paths
     runs-on: ubuntu-latest
 

diff --git a/.github/workflows/health-metrics-pull-request.yml b/.github/workflows/health-metrics-pull-request.yml
@@ -39,7 +39,7 @@ env:
 jobs:
   binary-size:
     name: Binary Size
-    if: (${{ github.event.workflow_run.conclusion }} == 'success' && (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]'))
+    if: (${{ github.event.workflow_run.conclusion == 'success'}} && (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]'))
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -67,7 +67,7 @@ jobs:
         run: yarn size-report
   modular-export-size:
     name: Binary Size For Modular Exports
-    if: (${{ github.event.workflow_run.conclusion }} == 'success' && (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]'))
+    if: (${{ github.event.workflow_run.conclusion == 'success'}} && (github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)) && (github.actor != 'dependabot[bot]'))
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml
@@ -38,7 +38,7 @@ jobs:
   # Auth and Firestore are built and executed in their own jobs in an attempt to reduce flakiness.
   test-the-rest:
     name: (bulk) Node.js and Browser (Chrome) Tests
-    if: ${{ github.event.workflow_run.conclusion }} == 'success'
+    if: ${{ github.event.workflow_run.conclusion == 'success'}}
     runs-on: ubuntu-latest
     steps:
     # install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo
@@ -137,7 +137,7 @@ jobs:
 
   test-firestore:
     name: (Firestore) Node.js and Browser (Chrome) Tests
-    if: ${{ github.event.workflow_run.conclusion }} == 'success'
+    if: ${{ github.event.workflow_run.conclusion == 'success'}}
     runs-on: ubuntu-latest
     steps:
     # install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo
@@ -180,7 +180,7 @@ jobs:
         path-to-lcov: ./lcov-all.info
       continue-on-error: true
   test-firestore-integration:
-    if: ${{ github.event.workflow_run.conclusion }} == 'success'
+    if: ${{ github.event.workflow_run.conclusion == 'success'}}
     strategy:
       fail-fast: false
       matrix: