Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS streamable HTTPCallabe functions #14290

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

eBlender
Copy link

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

Add initial support for Streamable functions.
Change call to AsyncThrowingStream<HTTPSCallableResult, Error>
testing check.sh
Remove old test function.
Remove old test
Add a full working test for stremableFunction. Refactor.
Copy link

google-cla bot commented Dec 27, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Add Json capabilities to parse an HTTP result back and forth.

Updating Unit tests.
Add doc for processResponseDataForStreamableContent.
Update func to have a callback.
Update UnitTests
Remove spaces.
@eBlender eBlender changed the title I os stremable functions iOS streamable HTTPCallabe functions Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant