Add linkDomain support for ActionCodeSettting. This will generate Hosting-formatted email link. #13991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
paulb777
reviewed
Oct 29, 2024
paulb777
reviewed
Oct 29, 2024
| @@ -42,6 +42,9 @@ import Foundation | |||
| /// The Firebase Dynamic Link domain used for out of band code flow. | |||
| @objc open var dynamicLinkDomain: String? | |||
There was a problem hiding this comment.
Should this be marked deprecated? Or wait until next release?
There was a problem hiding this comment.
When I mark this as deprecated, our test failed due to build warnings. Any suggestions? I still want to keep the dynamicLinkDomain tests because both solutions will be available until FDL sunset.
There was a problem hiding this comment.
You can temporarily add --allow-warnings with a comment to the pod lib lint test invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including error codes and sample app change
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.