Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Convert LoginView to SwiftUI #13628

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

[Auth] Convert LoginView to SwiftUI #13628

wants to merge 17 commits into from

Commits on Sep 10, 2024

  1. [Auth] Convert LoginView to SwiftUI

    @ncooke3
    ncooke3 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    540d83d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Refactor button logic into custom view

    @ncooke3
    ncooke3 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aff55c3 View commit details
    Browse the repository at this point in the history

  2. Style FirebaseAuth/Tests/SampleSwift/AuthenticationExample/Utility/Ex… 

    …tensions.swift
    @ncooke3
    ncooke3 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    62d639a View commit details
    Browse the repository at this point in the history

  3. Disable buttons if textfields are empty

    @ncooke3
    ncooke3 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4411673 View commit details
    Browse the repository at this point in the history

  4. Implement action handlers

    @ncooke3
    ncooke3 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    413e9a2 View commit details
    Browse the repository at this point in the history

  5. Style FirebaseAuth/Tests/SampleSwift/AuthenticationExample/CustomView… 

    …s/LoginViewSwiftUI.swift
    @ncooke3
    ncooke3 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aea8b4b View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'main' into nc/swiftui-auth

    @ncooke3
    ncooke3 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    589ade5 View commit details
    Browse the repository at this point in the history

  2. Add title and description

    @ncooke3
    ncooke3 committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    bb0e4ff View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Bump minimum deployment target to iOS 15

    @ncooke3
    ncooke3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7d96b99 View commit details
    Browse the repository at this point in the history

  2. Implement verification code flow in new SwiftUI view

    @ncooke3
    ncooke3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    243afcb View commit details
    Browse the repository at this point in the history

  3. Remove UIKit-based LoginView.swift

    @ncooke3
    ncooke3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7a6c843 View commit details
    Browse the repository at this point in the history

  4. Rename LoginViewSwiftUI.swift to LoginView.swift

    @ncooke3
    ncooke3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    44dad32 View commit details
    Browse the repository at this point in the history

  5. Remove unneeded extension and finish renaming

    @ncooke3
    ncooke3 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    49dfae1 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Refactor out login button action handler

    @ncooke3
    ncooke3 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c71e9fe View commit details
    Browse the repository at this point in the history

  2. [skip ci] Refactor out login button action handler (2)

    @ncooke3
    ncooke3 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8424f5f View commit details
    Browse the repository at this point in the history

  3. [skip ci] Refactor out login button action handler (3)

    @ncooke3
    ncooke3 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    12758ed View commit details
    Browse the repository at this point in the history

  4. [skip ci] Move alert view code

    @ncooke3
    ncooke3 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    da98405 View commit details
    Browse the repository at this point in the history