Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recaptcha Enterprise Unit Tests #13614

Open
wants to merge 3 commits into
base: rce-phone-tests
Choose a base branch
from
Open

Recaptcha Enterprise Unit Tests #13614

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2639bcb
add VerifyPhoneNumberWithRceAuditSuccess test
srushtisv Sep 10, 2024
5e61d9f
Updates from review
srushtisv Sep 17, 2024
c273802
adding invalidRce test in audit mode
srushtisv Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions FirebaseAuth/Tests/Unit/PhoneAuthProviderTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,45 @@
)
}

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the comment style is from the port from the old Objective-C unit tests.

For new tests, it might be better to use the triple-slash docc format used in the library implementation - https://developer.apple.com/documentation/xcode/writing-symbol-documentation-in-your-source-files

@fn testVerifyPhoneNumberWithRceAudit
@brief Tests a successful invocation of @c verifyPhoneNumber with recaptcha enterprise in audit mode
*/
func testVerifyPhoneNumberWithRceAuditSuccess() async throws {
initApp(#function)
let auth = try XCTUnwrap(PhoneAuthProviderTests.auth)
let provider = PhoneAuthProvider.provider(auth: auth)
let mockVerifier = FakeAuthRecaptchaVerifier(captchaResponse: kCaptchaResponse)
AuthRecaptchaVerifier.setShared(mockVerifier, auth: auth)
rpcIssuer.rceMode = "AUDIT"
let requestExpectation = expectation(description: "verifyRequester")
rpcIssuer?.verifyRequester = { request in
XCTAssertEqual(request.phoneNumber, self.kTestPhoneNumber)
XCTAssertEqual(request.captchaResponse, self.kCaptchaResponse)
XCTAssertEqual(request.recaptchaVersion, "RECAPTCHA_ENTERPRISE")
XCTAssertEqual(request.codeIdentity, CodeIdentity.empty)
requestExpectation.fulfill()
do {
try self.rpcIssuer?
.respond(withJSON: [self.kVerificationIDKey: self.kTestVerificationID])
} catch {
XCTFail("Failure sending response: \(error)")
}
}
do {
let result = try await provider.verifyClAndSendVerificationCodeWithRecaptcha(
toPhoneNumber: kTestPhoneNumber,
retryOnInvalidAppCredential: false,
uiDelegate: nil,
recaptchaVerifier: mockVerifier
)
XCTAssertEqual(result, kTestVerificationID)
} catch {
XCTFail("Unexpected error")
}
await fulfillment(of: [requestExpectation], timeout: 5.0)
}

/** @fn testVerifyPhoneNumberInTestMode
@brief Tests a successful invocation of @c verifyPhoneNumber:completion: when app verification
is disabled.
Expand Down
Loading