rCE Unit Tests #13547
Open
rCE Unit Tests #13547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
author Pragati <[email protected]> 1724775429 -0700 committer Pragati <[email protected]> 1725423960 -0700 Unit Tests drafted tests adding mock rce enforce test remove wip test add error cases lint changes line fix CI failures modifying objc methods to use swift implementations remove ios only enablement enum address PR feedback adding mock rce enforce test lint changes modifying objc methods to use swift implementations remove ios only enablement enum add/remove rebasing changes
pragatimodi
force-pushed
the
rce-phone-tests
branch
from
b5d1882
to
17796b5
Compare
Xiaoshouzi-gh
approved these changes
Sep 5, 2024
FirebaseAuth/Sources/Swift/AuthProvider/PhoneAuthProvider.swift
Outdated
Show resolved
Hide resolved
paulb777
requested changes
Sep 5, 2024
paulb777
approved these changes
Sep 6, 2024
Sambit650
approved these changes
Sep 15, 2024
| uiDelegate: nil, | ||
| recaptchaVerifier: mockVerifier | ||
| ) | ||
| // XCTAssertEqual(result, kTestVerificationID) |
There was a problem hiding this comment.
very minor: we can remove this commented line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recaptcha Enterprise Unit Testing