add /v2 imports back in #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berlioz
force-pushed
the
vf_add_v2_back_in
branch
from
d113fd2 to
64e6746
Compare
Berlioz
force-pushed
the
vf_add_v2_back_in
branch
from
64e6746 to
251fe2f
Compare
|
Can you also add Firebase 13 to the peer deps? |
taeold
approved these changes
Dec 18, 2024
Co-authored-by: Dennis Kugelmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#243 handles the breaking change in firebase-functions 6 imports, which changed the default meaning of importing just 'firebase-functions' from v1 to v2, but breaks prior versions for that same reason. We should be able to support both by always specifying v1 or v2 in an import.