-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ExprTk #2825
base: master
Are you sure you want to change the base?
Update ExprTk #2825
Conversation
ArashPartow
commented
Nov 4, 2024
•
edited
Loading
edited
- Update ExprTk to 0.0.3 Release notes: https://www.partow.net/programming/exprtk/exprtk_release_notes_v0.0.3.txt
- Adaptor update
- Minor fixes and cleanups in exprtk, scalar, computed functions
Signed-off-by: Arash Partow <[email protected]>
Signed-off-by: Arash Partow <[email protected]>
a8d3a1c
to
0687b1d
Compare
@texodus Looks like a couple of adaptor methods and free functions need to be added to perspective::t_tscalar:
I'm ok with adding them, would you want it all in the same PR or two PRs, initially the additional adaptor methods and then this PR? |
One PR would be ideal. |
7658f2e
to
ccb4b1c
Compare
I'm not sure if you can see our CI logs externally, but this PR does not compile for different reasons on every architecture we support. I have not had time to test this on anything but my development machine yet, but I've rebased your PR and fixed the local compilation errors here, which you can cherry pick. |
d3ce42f
to
a2c2161
Compare
a2c2161
to
faba9b9
Compare
baebcb1
to
05e8878
Compare
Finally got all the tests passing. Minor issues some of the test results, which revealed a parsing issue in ExprTk. That being said there is a change I couldn't resolve:
It seems the use of The main reason for this particular change was to properly seed the engine, as the way it is currently being setup is not correct. It will use an internal state based on whatever is the memory contents of the allocation. Which could be random or all zeros etc. |