Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR is to resolve : [EPIC] Allow users to be able to edit palette and default color theme in existing design system #820 #972

Open
wants to merge 27 commits into
base: epic-820
Choose a base branch
from

Conversation

omesh-omg
Copy link
Contributor

Adding three pages /steps.

  1. Core Settings
  2. Build Color Palette
  3. Light and Dark Mode

Resolves issue:
#820
#914
#916
#917
#918
#919
#920

@omesh-omg omesh-omg changed the title Issue#914 impliment core settings page This PR is to resolve : [EPIC] Allow users to be able to edit palette and default color theme in existing design system #820 Jul 25, 2024
@omesh-omg omesh-omg self-assigned this Jul 25, 2024
@aaronreed708
Copy link
Contributor

Hey @omesh-omg, sorry that it took me so long to get back to you. So to fix the ESLint errors, you could just add another * in the copyright header (to match the headers in the other legacy files...which I updated with the ESLint changes). But since you are adding new files, you should really give them the new SPDX header like you did for the other PR that you did that added a new file. You really shouldn't add a copyright header saying that Discover created the file when you did :-)

So for your new files, you should use:

/**
 * SPDX-License-Identifier: Apache-2.0
 * Copyright 2024 FINOS A11y Theme Builder contributors - see NOTICE file
 */

I'm currently experiencing an issue running Theme Builder on my machine so I can't run and test your latest code. I'll let you know when I have it resolved. I'll try to at least code review the code tomorrow.

@omesh-omg
Copy link
Contributor Author

Yessss, I didn't ask for it because I just switched my os to Linux I thought may be there is some issue with my OS it is not able to clone properly and I didn't which way to fix manually or changing eslin** file 🙃🙃

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit 53dd1bb
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/66dc74e50ae236000873bda6
😎 Deploy Preview https://deploy-preview-972--glistening-gecko-6b417a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for dapper-ganache-45a60b ready!

Name Link
🔨 Latest commit 53dd1bb
🔍 Latest deploy log https://app.netlify.com/sites/dapper-ganache-45a60b/deploys/66dc74e51fb58800082fadf5
😎 Deploy Preview https://deploy-preview-972--dapper-ganache-45a60b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants