Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CrankIndicator from Lua's CoreLib/UI #94

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

kaylanx
Copy link
Contributor

@kaylanx kaylanx commented Oct 3, 2024

Implement CrankIndicator from Lua's CoreLib/UI

Might be good to figure out a way to separate this out into a separate sub package, then game devs can decide to pull in the indicator or not.

Changes Scale to an enum to be more swifty, no point in having if statements like

 if !([1, 2, 4, 8].contains(scale)) {
                System.error("scale must be 1, 2, 4, or 8")
                scale = 1
            }

when an enum can make that redundant.

Copy link
Owner

@finnvoor finnvoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the PR!

@finnvoor finnvoor enabled auto-merge (squash) October 7, 2024 18:08
@finnvoor finnvoor merged commit 59da2b3 into finnvoor:main Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants