Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Comply new policies INTER-276 #57

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

Orkuncakilkaya
Copy link
Contributor

@Orkuncakilkaya Orkuncakilkaya commented Dec 20, 2023

This integration works for Angular version between 13 and 17 (latest)
Angular 17 only works with Typescript >=4.9.3 <5.3.0. So it doesn't supports Typescript 5.3.0 or 5.3.3.
I updated our libraries requirements as:

- TypeScript >=4.6
- Angular 13+

CC: @JuroUhlar @ilfa

Copy link

github-actions bot commented Dec 20, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 64.1% 25/39
🟢 Branches 100% 2/2
🔴 Functions 23.08% 3/13
🟡 Lines 60% 21/35

Test suite run success

5 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from dc05339

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟡 All files 64.1 100 23.07 60
🔴  src 0 100 0 0
🔴   public-api.ts 0 100 0 0 5-24
🟢  src/lib 95.83 100 75 95
🟢   fingerprintjs-pro-angular.module.ts 100 100 100 100
🟢   fingerprintjs-pro-angular.service.ts 93.75 100 66.66 92.85 67
🟢   version.ts 100 100 100 100
🟡  src/lib/tokens 66.66 100 0 66.66
🟡   fingerprintjs-pro-angular-settings-token.ts 66.66 100 0 66.66 8

JuroUhlar
JuroUhlar previously approved these changes Dec 20, 2023
README.md Outdated Show resolved Hide resolved
Copy link

This PR will not create a new release 🚀

@Orkuncakilkaya Orkuncakilkaya merged commit fa50558 into main Dec 22, 2023
4 checks passed
@Orkuncakilkaya Orkuncakilkaya deleted the docs/readme-policies-inter-276 branch December 22, 2023 08:52
@fingerprint-dx-team
Copy link

🎉 This PR is included in version 2.0.0-test.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fingerprint-dx-team
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants