Attempt to handle Issue #53 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanleonardo
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
suggestion: @fillipe-gsm, the Lin-Kernighan heuristic assumes the existence of at least 4 nodes (named a, b, c, d) that play important roles in defining the neighborhood of a solution. If the problem is small, with less than 4 nodes, the heuristic does not apply. In this case, it is preferable to solve the problem using brute force.
I committed this suggestion, what do you think? If it's ok for you, I suggest merging the PR.
|
I cannot approve the PR since I was the one who opened it (I just realized it now 🦆 ). Thanks for the help, @luanleonardo , I'll merge it the way it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the inner Lin Kernighan loops gets hanged forever when the incoming distance matrix has only two nodes.
This seems to happen regardless of the matrix being symmetric or asymmetric.
In this pull request I setup a test that should pass once the bug has been solved.
I leave the rest to @luanleonardo to handle it properly.