Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Removed unnecessary configurations #16569

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Dec 6, 2024

Summary

We removed Store, Preview and Stable configurations in #16566. This is follow-up PR for it in order to remove leftovers.

We now have only Debug and Release.
While we have 4 release destinations in Release configuration: SideloadPreview, SideloadStable, StorePreview and StoreStable, these are configured within our CD pipeline for the simplicity in project configurations since these have differences only in packaging and publish destination.

@0x5bfa 0x5bfa changed the title 5bfa/gh config followup Code Quality: Removed unnecessary configurations Dec 6, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Dec 6, 2024

Should I include follow up for CD for store submission to add a checkbox

@yaira2
Copy link
Member

yaira2 commented Dec 6, 2024

Should I include follow up for CD for store submission to add a checkbox

That would be great! Please open a separate PR for this.

@0x5bfa
Copy link
Member Author

0x5bfa commented Dec 10, 2024

PTAL

@@ -10,7 +10,7 @@
<GenerateAppInstallerFile>False</GenerateAppInstallerFile>
<AppxAutoIncrementPackageRevision>False</AppxAutoIncrementPackageRevision>
<AppxSymbolPackageEnabled>True</AppxSymbolPackageEnabled>
<AppxBundlePlatforms>x86|x64|arm64</AppxBundlePlatforms>
Copy link
Member

@yaira2 yaira2 Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep x86

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes are needed for this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants