-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Removed unnecessary configurations #16569
Open
0x5bfa
wants to merge
16
commits into
files-community:main
Choose a base branch
from
0x5bfa:5bfa/GH-ConfigFollowup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+43
−1,288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
changed the title
5bfa/gh config followup
Code Quality: Removed unnecessary configurations
Dec 6, 2024
Should I include follow up for CD for store submission to add a checkbox |
yaira2
reviewed
Dec 6, 2024
That would be great! Please open a separate PR for this. |
hez2010
reviewed
Dec 6, 2024
PTAL |
yaira2
reviewed
Dec 11, 2024
@@ -10,7 +10,7 @@ | |||
<GenerateAppInstallerFile>False</GenerateAppInstallerFile> | |||
<AppxAutoIncrementPackageRevision>False</AppxAutoIncrementPackageRevision> | |||
<AppxSymbolPackageEnabled>True</AppxSymbolPackageEnabled> | |||
<AppxBundlePlatforms>x86|x64|arm64</AppxBundlePlatforms> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep x86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We removed Store, Preview and Stable configurations in #16566. This is follow-up PR for it in order to remove leftovers.
We now have only Debug and Release.
While we have 4 release destinations in Release configuration: SideloadPreview, SideloadStable, StorePreview and StoreStable, these are configured within our CD pipeline for the simplicity in project configurations since these have differences only in packaging and publish destination.