Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hides explorer icons feature also vscode did the tasks.json mo… #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ node_modules
[._]*.sw[a-p]
[._]s[a-v][a-z]
[._]sw[a-p]
.vscode

# Project-specific
*.vsix
Expand Down
47 changes: 38 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,44 @@
"theme"
],
"contributes": {
"iconThemes": [{
"id": "file-icons",
"label": "File Icons",
"path": "./icons/file-icons-icon-theme.json"
},{
"id": "file-icons-colourless",
"label": "File Icons (Colourless)",
"path": "./icons/file-icons-colourless-icon-theme.json"
}]
"iconThemes": [
{
"id": "file-icons",
"label": "File Icons",
"path": "./icons/file-icons-icon-theme.json"
},
{
"id": "file-icons-colourless",
"label": "File Icons (Colourless)",
"path": "./icons/file-icons-colourless-icon-theme.json"
}
],
"commands": [
{
"command": "file-icons-colourless.hidesExplorerArrows",
"title": "%command.hidesExplorerArrows%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally, and received the following error:

Command '%command.hidesExplorerArrows%' resulted in an error (command 'file-icons.hidesExplorerArrows' not found)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to replicate that error

},
{
"command": "file-icons.hidesExplorerArrows",
"title": "%command.hidesExplorerArrows%"
}
],
"configuration": {
"type": "object",
"title": "%configuration.title%",
"properties": {
"file-icons-colourless.hidesExplorerArrows": {
"type": "boolean",
"default": false,
"description": "%configuration.hidesExplorerArrows%"
},
"file-icons.hidesExplorerArrows": {
"type": "boolean",
"default": false,
"description": "%configuration.hidesExplorerArrows%"
}
}
}
},
"scripts": {
"import": "make update",
Expand Down