Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Heroicon Icon Handling to Use Enums #15495

Merged
merged 10 commits into from
Feb 1, 2025
Merged

Refactor Heroicon Icon Handling to Use Enums #15495

merged 10 commits into from
Feb 1, 2025

Conversation

leandrocfe
Copy link
Contributor

Description

Refactored Heroicon icon handling across the codebase to use Enums instead of string values:

  • Updated PHP classes to reference Enums for icons.
  • Modified Blade views to use Enums instead of string values.
  • Adjusted tests / resolved icon type issues.
  • Rebuilt snapshots.

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@leandrocfe leandrocfe requested a review from danharrin January 31, 2025 17:39
@danharrin danharrin merged commit ac809c2 into filamentphp:4.x Feb 1, 2025
4 checks passed
@danharrin
Copy link
Member

Thanks!

@danharrin danharrin added the chore label Feb 1, 2025
@danharrin danharrin modified the milestones: v4, v4.0.0-alpha1 Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin Awaiting requested review from danharrin

Assignees
No one assigned
Labels
chore
Projects
Roadmap
Status: Done
Milestone
v4.0.0-alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrocfe @danharrin