fix: compatibility with vue-tsc 2.x

[so1ve]

fixes #306, close #321

This is a naive fix - it may cause problems described in #306 (comment), but it will avoid crashes.

I'm still working on a complete solution.

Fixed, but requires installing @vue/language-core as a dependency, which may cause version mismatch.

Ran e2e tests locally and passed, the ci is failing due to d ts building issues and low nodejs version

[changeset-bot]

🦋 Changeset detected

Latest commit: ef0479f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
vite-plugin-checker	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for vite-plugin-checker ready!

Name	Link
🔨 Latest commit	ef0479f
🔍 Latest deploy log	https://app.netlify.com/sites/vite-plugin-checker/deploys/667f8e4bf7c0fc0008dd60dd
😎 Deploy Preview	https://deploy-preview-327--vite-plugin-checker.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[fi3ework]

I checked the PR code and found vscode-uri blocks test:unit. It has been bumped to 3.0.8 in lockfile and the type exports has been fixed. We could change https://github.com/fi3ework/vite-plugin-checker/blob/0a2a2e04a79bfb90c38f1458467c749978c7cdbb/packages/vite-plugin-checker/src/checkers/vls/diagnostics.ts#L27 and https://github.com/so1ve/vite-plugin-checker/blob/main/packages/vite-plugin-checker/src/checkers/vls/diagnostics.ts#L27-L28 to normal write up.

[so1ve]

Invalid back references breaks dts build, any thoughts?

[fi3ework]

Invalid back references breaks dts build, any thoughts?

Just follow the new version of typescript's instruction and change to const myRegexp = /([^\s'"]([^\s'"]*(['"])([^\x03]*?)\3)+[^\s'"]*)|[^\s'"]+|(['"])([^\x05]*?)\5/gi would be fine.

[so1ve]

I suppose \x03 is hex while \3 is a back reference?

[fi3ework]

I also found that multiple-hmr and multiple-reload test case has some existing flaw which will break in this PR as it's using the project's thought ESLint config. I think it could be rewritten based on eslint-default and add one line in the main.ts to trigger TS error. And update vite.config.ts alongside is enough. And the snapshot could be updated totally.

import { text } from './text'

+ let count: string = 0
var hello = 'Hello'

const rootDom = document.querySelector('#root')!
rootDom.innerHTML = hello + text

export {}

import { defineConfig } from 'vite'
import checker from 'vite-plugin-checker'

export default defineConfig({
  plugins: [
    checker({
+      typescript: true,
      eslint: {
        lintCommand: 'eslint ./src --ext .ts',
      },
    }),
  ],
})

[fi3ework]

I suppose \x03 is hex while \3 is a back reference?

Guess we could ts-expect-error as per microsoft/TypeScript#58416.

[fi3ework]

@so1ve Could you help to check the Windows CI issue, it's relatively slow for me to test it on CI and I can't reach my Windows machine until next week. 🥺

[so1ve]

Hi @fi3ework, I don't have enough time to work on windows tests recently, but I can work on this issue in two days. How about we merge this PR first, and then I will submit another PR to fix it?

[fi3ework]

Hi @fi3ework, I don't have enough time to work on windows tests recently, but I can work on this issue in two days. How about we merge this PR first, and then I will submit another PR to fix it?

Sure, I'll merge this PR tonight (I'll try to fix the Windows CI one more time before that 🥲).

[fi3ework]

GitHub is down https://www.githubstatus.com/incidents/9vwllhs2w1kj, I can't merge the PR right now. It's late tonight, I'll try to merge this PR tomorrow morning.

[fi3ework]

@so1ve Thanks for the hard work, I really appreciate that. Looking forward to releasing this after fixing the left comment.

• CI failed on Windows
• vue-tsc^2 not works with ts^4 (expected?)

[armano2]

windows test seem to be failing due to jest-serializer-path normalization, path drive path is replaced with val => val.replace(/[a-zA-Z]:\\/g, "\\") and this seem to not be present in https://github.com/fi3ework/vite-plugin-checker/blob/56761d092f4c80f321da96bb1bab755f10edc45c/playground/serializers.ts

i created a PR, that hack "fixes" this issue #313

[so1ve]

Hi @fi3ework, yes, we don't support ts 4. We rely on ts 5 specific apis.

[fi3ework]

@so1ve Hmm, I'm wondering why peer dep is set * of vue-tsc https://www.npmjs.com/package/vue-tsc?activeTab=code

[so1ve]

Yeah, it would be better to point it to ^5. Will do, thanks!