Incorrect toString for invalid UTF8 multibyte codepoints #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
force-pushed
the
incorrect-tostring-replacement
branch
from
5d37ad9
to
44719cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example
Buffer.from(Buffer.from([0xE0, 0xAC]).toString())produces<Buffer ef bf bd>with the native Node Buffer while this package currently outputs<Buffer ef bf bd ef bf bd>. So it somehow tries to match multiple bytes even if some of them are missing and doesn't emit a replacement character for every single byte.This only adds failing tests because I'm not sure how this should be fixed