Add a "sponge" reader and writer #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for _, k := range r.keys { | ||
| msg := verify(nil, r.buf.Bytes(), r.ttl, time.Now(), k) | ||
| if msg != nil { | ||
| r.buf = bytes.NewBuffer(msg) |
|
I'd much rather leave the existing implementations alone and write the Reader and Writer in terms of those if possible. |
| b := make([]byte, encodedLen(w.buf.Len())) | ||
| n := gen(b, w.buf.Bytes(), iv, time.Now(), w.key) | ||
|
|
||
| if _, w.err = io.Copy(w.w, bytes.NewBuffer(b[:n])); w.err != nil { |
|
Other general thoughts:
|
|
Oh, I see, this patch doesn't reuse the existing public functions because it works on the not-base64 binary bytes. How do we feel about having binary-mode as a rider? I'd rather we make a decision on #7 first, then this patch can have a tighter scope. |
|
Wow. Well, you have discovered what I meant by substandard. It also lacks basic documentation, the |
And make old method use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a substandard implementation of #8.
This would close #7, since the
base64encoding is now optional.