Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete complete used functions and constants #606

Open
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

Declspeck
Copy link
Contributor

This add completion for

use function SomeNamespace\some_function;
use const SomeNamespace\SOME_CONST;

some_fun| // Completes to some_function
SOME_CONS| // Completes to SOME_CONST

This is based on #605 (Note - not the speedup PR, but another continuation of it), so this cannot be merged before #605 and #599 are merged.

@codecov
Copy link

codecov bot commented Feb 24, 2018

Codecov Report

Merging #606 into master will increase coverage by 0.35%.
The diff coverage is 90.79%.

@@             Coverage Diff              @@
##             master     #606      +/-   ##
============================================
+ Coverage     81.63%   81.99%   +0.35%     
- Complexity      910      948      +38     
============================================
  Files            61       61              
  Lines          2075     2233     +158     
============================================
+ Hits           1694     1831     +137     
- Misses          381      402      +21
Impacted Files Coverage Δ Complexity Δ
src/Server/TextDocument.php 75.55% <100%> (+0.18%) 57 <0> (+1) ⬆️
src/Index/AbstractAggregateIndex.php 86.04% <71.42%> (-7.44%) 26 <6> (ø)
src/Index/Index.php 77.41% <82.5%> (+7.6%) 54 <32> (+32) ⬆️
src/FqnUtilities.php 83.87% <90.47%> (+13.87%) 0 <0> (ø) ⬇️
src/CompletionProvider.php 94.39% <96.85%> (-0.12%) 113 <74> (+5)

@felixfbecker
Copy link
Owner

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants