Eliminate dependency on arcstr patch that isn't upstream yet. #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBSP relies on bincode version 2.0.0-rc3, which was released at the end of March 2023. DBSP also uses arcstr and we want to serialize and deserialize `ArcStr`s with bincode. Unfortunately, arcstr doesn't support bincode 2.0 yet and won't until bincode 2.0 finally gets released[1], which could be a long time, so we have a patch in Cargo.toml to support that. We'd like to publish DBSP to crates.io[2], but we can't if it depends on patches, so it seems best to avoid them. This commit drops the patch and switches to using #[bincode(with_serde)] to serialize ArcStr fields. [1]: thomcc/arcstr#45 [2]: #14 Signed-off-by: Ben Pfaff <[email protected]> Fixes: #395
mihaibudiu
approved these changes
Jul 26, 2023
gz
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBSP relies on bincode version 2.0.0-rc3, which was released at the end of March 2023. DBSP also uses arcstr and we want to serialize and deserialize
ArcStrs with bincode. Unfortunately, arcstr doesn't support bincode 2.0 yet and won't until bincode 2.0 finally gets released1, which could be a long time, so we have a patch in Cargo.toml to support that.We'd like to publish DBSP to crates.io2, but we can't if it depends on patches, so it seems best to avoid them. This commit drops the patch and switches to using #[bincode(with_serde)] to serialize ArcStr fields.
Fixes: #395