Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve java-functions to work without JAVA_HOME #120

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

mizdebsk
Copy link
Member

@mizdebsk mizdebsk commented Oct 4, 2024

CC @fridrich

@mizdebsk
Copy link
Member Author

mizdebsk commented Oct 4, 2024

Also search for JAVACMD under JAVA_HOME only if it's set - otherwise ${JAVA_HOME}/bin/java expands to just /bin/java and likely matches some Java, possibly different one than from PATH via which.

@fridrich
Copy link
Contributor

fridrich commented Oct 4, 2024

I also think that this would actually justify a 6.3.2 if all the scripts are cleaned up. It is such an improvement.

@mizdebsk
Copy link
Member Author

mizdebsk commented Oct 4, 2024

I also think that this would actually justify a 6.3.2

I will make a release with current fixes/improvements.

There is another one I'd like to do (#121), but it's a potentially breaking change, so I'll defer it to 7.0.0

@mizdebsk mizdebsk merged commit 67fdd10 into fedora-java:master Oct 4, 2024
1 check passed
@mizdebsk mizdebsk deleted the java-functions branch October 4, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants