Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add legal date formats #5533

Merged
merged 1 commit into from
Aug 7, 2023
Merged

add legal date formats #5533

merged 1 commit into from
Aug 7, 2023

Conversation

tmpayton
Copy link
Contributor

@tmpayton tmpayton commented Aug 4, 2023

Summary (required)

This PR fixes the issue we are having with legal dates. These changes somehow got lost when rolling back the initial Flask deployment and deploying the flask hotfix. Here is the previous PR #5489

Required reviewers 1-2 developers

Impacted areas of the application

General components of the application that this PR will affect:

  • legal.py

How to test

This can be tested locally or on dev

local:

  1. Follow the wiki to setup and test elastic search locally
  2. flask run
  3. Test date fields under the legal search endpoint including:
  • af_max_fd_date
  • af_min_fd_date
  • af_max_rtb_date
  • af_min_rtb_date
  • case_max_close_date
  • case_min_close_date
  • case_max_open_date
  • case_min_open_date
  • ao_max_request_date
  • ao_min_request_date
  • ao_max_issue_date
  • ao_min_issue_date

on stage:
Test date filters on legal search pages

example urls:
https://stage.fec.gov/data/legal/search/murs/?search_type=murs&sort=-case_no&search=&case_no=&case_respondents=&case_min_open_date=&case_max_open_date=&case_min_close_date=06%2F06%2F2023&case_max_close_date=07%2F06%2F2023

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #5533 (a6521e4) into release/public-20230808 (1e56b9a) will decrease coverage by 0.09%.
The diff coverage is 11.11%.

@@                     Coverage Diff                     @@
##           release/public-20230808    #5533      +/-   ##
===========================================================
- Coverage                    85.58%   85.50%   -0.09%     
===========================================================
  Files                           81       81              
  Lines                         8228     8237       +9     
===========================================================
+ Hits                          7042     7043       +1     
- Misses                        1186     1194       +8     
Files Changed Coverage Δ
webservices/resources/legal.py 62.22% <11.11%> (-1.51%) ⬇️

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@cnlucas cnlucas closed this Aug 7, 2023
@cnlucas cnlucas reopened this Aug 7, 2023
Copy link
Member

@cnlucas cnlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on stage and works for me 👍🏻

@cnlucas cnlucas merged commit 4740690 into release/public-20230808 Aug 7, 2023
2 checks passed
@tmpayton tmpayton deleted the fix-legal-dates branch July 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants