-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inclusion/exclusion operators on VFS #80
Implement inclusion/exclusion operators on VFS #80
Conversation
import { expect, it, describe } from 'vitest' | ||
|
||
import applyGlobs from './apply-globs' | ||
import { joinFromRoot, parseIntoFsdRoot } from '../../../steiger-plugin-fsd/src/_lib/prepare-test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we create a shared folder for test utilities for both Steiger and the fsd-plugin? Because, maybe it's just me, but I don't really like this import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just copy-paste that file, no need to set up a whole separate folder for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you'd like to do it before merging, because I'm honestly fine merging it as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to copy that file after all, so Steiger package has a separate test utility. Also fixed several minor things in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for this, this is huge! No stress about taking more time, hope everything is alright with you.
I'm very satisfied with this PR, especially the extensive test coverage. Great job!
import { expect, it, describe } from 'vitest' | ||
|
||
import applyGlobs from './apply-globs' | ||
import { joinFromRoot, parseIntoFsdRoot } from '../../../steiger-plugin-fsd/src/_lib/prepare-test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just copy-paste that file, no need to set up a whole separate folder for it
Resolves #66
Hi @illright
Sorry for the delay. I wanted to complete this task earlier, but a terrible force majeure happened at the beginning of the week.
… but finally here’s my solution.
Just a few annotations for it: