Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the workflow to publish package previews #145

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Add the workflow to publish package previews #145

merged 3 commits into from
Dec 19, 2024

Conversation

illright
Copy link
Member

@illright illright commented Dec 9, 2024

This is an attempt to add pkg.pr.new

Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: f7bcb36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

daniilsapa
daniilsapa previously approved these changes Dec 18, 2024
Copy link
Collaborator

@daniilsapa daniilsapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good so far, but I think we need a real run to see if it runs as expected

@illright
Copy link
Member Author

@daniilsapa could you approve it again please? it only runs when someone approves, and the last run failed (I think I fixed it now)

.github/workflows/pkg-pr-new.yaml Fixed Show fixed Hide fixed
.github/workflows/pkg-pr-new.yaml Fixed Show fixed Hide fixed
@daniilsapa
Copy link
Collaborator

daniilsapa commented Dec 18, 2024

I see some warnings called out by CodeQL. They suggested us adding explicit permissions for the workflow to improve security and ensure it does not touch what it mustn't.

e.g.

name: Publish Approved Pull Requests to pkg.pr.new
permissions:
  contents: read
  pull-requests: write

Copy link
Collaborator

@daniilsapa daniilsapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

.github/workflows/pkg-pr-new.yaml Outdated Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

npm i https://pkg.pr.new/feature-sliced/steiger@145
npm i https://pkg.pr.new/feature-sliced/steiger/@steiger/toolkit@145
npm i https://pkg.pr.new/feature-sliced/steiger/@feature-sliced/steiger-plugin@145

commit: f7bcb36

@illright illright merged commit 58c325a into master Dec 19, 2024
13 checks passed
@illright illright deleted the pkg-pr-new branch December 19, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants