Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-ui-in-app rule #101

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Conversation

Espate
Copy link
Contributor

@Espate Espate commented Sep 17, 2024

Resolves #77

@illright
Copy link
Member

Hi, thanks for taking a hand at it! I looked over the PR, looks solid, great job. One thing I'd like to add to it is to mention in the rationale of the rule that a valid use case for having a UI segment in App is for applications that only have a single page. They are rare, but they deserve a mention.

Also I noticed a couple of grammatical errors in the rationale, could you please run it through a spell checker like https://languagetool.org/?

@Espate
Copy link
Contributor Author

Espate commented Sep 18, 2024

Hi, thanks for taking a hand at it! I looked over the PR, looks solid, great job. One thing I'd like to add to it is to mention in the rationale of the rule that a valid use case for having a UI segment in App is for applications that only have a single page. They are rare, but they deserve a mention.

Hi, will update this part.

Also I noticed a couple of grammatical errors in the rationale, could you please run it through a spell checker like https://languagetool.org/?

Could you please point me out where exactly the errors are? I used the tool you referred to, and it didn't reveal any issues, at least in the free plan.

Screenshot 2024-09-18 at 08 45 13

@Espate Espate requested a review from illright September 19, 2024 11:49
Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with the rationale a bit more, let me know if that sounds okay. If so, then it's ready to merge! Thanks again :)

@Espate
Copy link
Contributor Author

Espate commented Sep 19, 2024

I played around with the rationale a bit more, let me know if that sounds okay. If so, then it's ready to merge! Thanks again :)

Sure, it works for me too. Thanks!

@illright illright merged commit 1bb6c4b into feature-sliced:master Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement no-ui-in-app
2 participants