-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-ui-in-app rule #101
Conversation
Hi, thanks for taking a hand at it! I looked over the PR, looks solid, great job. One thing I'd like to add to it is to mention in the rationale of the rule that a valid use case for having a UI segment in App is for applications that only have a single page. They are rare, but they deserve a mention. Also I noticed a couple of grammatical errors in the rationale, could you please run it through a spell checker like https://languagetool.org/? |
Hi, will update this part.
Could you please point me out where exactly the errors are? I used the tool you referred to, and it didn't reveal any issues, at least in the free plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with the rationale a bit more, let me know if that sounds okay. If so, then it's ready to merge! Thanks again :)
Sure, it works for me too. Thanks! |
Resolves #77