Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate code smells documentation pages into korean #767

Merged
merged 4 commits into from
Feb 1, 2025

Conversation

Gaic4o
Copy link
Contributor

@Gaic4o Gaic4o commented Nov 24, 2024

Background

We translated the cross-imports page, the desegmented page, and the routes page.

If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!

I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Copy link

netlify bot commented Nov 24, 2024

👷 Deploy request for pr-fsd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 13d4ce7

@Gaic4o
Copy link
Contributor Author

Gaic4o commented Jan 27, 2025

I re-examined and revised the whole thing.

@illright illright merged commit a9024ff into feature-sliced:master Feb 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants