Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DISTINCT
orGROUP BY
, incorrecttotal
is being returned. This PR fixes it by calculating the count using a subquery. More details below:DISTINCT
clause is used,clearSelect()
removes theDISTINCT
clause in the countBuilder query, hence returning non-distinct count. For eg:GROUP BY
clause is used,GROUP BY
is applied onCOUNT(`${name}.${id}`)
, which is useless, because rows returned byCOUNT
will not contain any column other thantotal
toGROUP BY
. Hence non-distinct rows are returned again.